Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zip and export its features #17

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

yujincheng08
Copy link
Contributor

@yujincheng08 yujincheng08 commented Jul 26, 2024

Fix #16

@matzefriedrich
Copy link
Owner

Aha, I see what you did here. Just let´s clarify so that I can better understand your intentions.

I guess you want to open the library for future patch versions; that´s why you widened the version of the zip dependency. I want to avoid potential issues with breaking changes introduced in minor versions, so it might be good to specify "2.1" instead of "2". This would allow patch updates, but breaking changes according to semantic versioning can be prevented.

Second, the fine-grained control of the zip crate's specific features is interesting but new. The list of default features you set matches the features enabled by the zip crate by default; at least, I can quickly grasp this from the zip documentation. Since the list of features is quite lengthy, I am afraid of the maintenance burden of keeping this in sync with the zip crate. Could you shed some light so I can better understand the benefit of it? I can only assume that it helps speed up the build.

@matzefriedrich matzefriedrich added the enhancement New feature or request label Jul 26, 2024
@yujincheng08
Copy link
Contributor Author

yujincheng08 commented Jul 26, 2024

@matzefriedrich

  • updated to "2.1" instead
  • my concern is to disable some features to reduce the binary size. we may only need some compression algorithms (e.g., deflate) or disable encrypt support in some cases (like embedded devices).

@matzefriedrich
Copy link
Owner

matzefriedrich commented Jul 26, 2024

@yujincheng08 If I get this right, to allow consumers of the zip extension crate to control its features, I need to "proxy" the zip crate features. This involves defining corresponding features in the extension crate's cargo. toml to make the respective features of the zip crate configurable.

@matzefriedrich matzefriedrich self-assigned this Jul 26, 2024
@matzefriedrich matzefriedrich merged commit 5c4685f into matzefriedrich:master Jul 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature selection on zip
2 participants